Replace UiAutomator onView with onElement #86
Conversation
The PromptBenchmark and BaselineProfileGenerator were updated to use `onElement` instead of the deprecated `onView` for UI interaction in tests.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @AjeshRPai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the UI Automator tests within the PromptBenchmark and BaselineProfileGenerator files. The core change involves migrating from the deprecated onView API to the more current onElement API for UI interactions. This ensures our UI tests are aligned with the latest recommendations and best practices for Android UI testing.
Highlights
- API Modernization: Replaced deprecated
onViewcalls withonElementin UI Automator test scripts. - Test File Updates: Updated
BaselineProfileGenerator.ktandPromptBenchmark.ktto reflect the API change.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly replaces the deprecated onView with onElement in the UI tests, which is a good practice. I've found a minor style inconsistency in one of the files and left a comment with a suggestion to fix it. Otherwise, the changes look good.
| onElement{ textAsString() == "Prompt" }.click() | ||
| onElement{ isEditable }.apply { |
There was a problem hiding this comment.
For consistency and adherence to Kotlin's coding conventions, it's best to add a space between the function name and the opening brace of the lambda expression.1
Style Guide References
| onElement{ textAsString() == "Prompt" }.click() | |
| onElement{ isEditable }.apply { | |
| onElement { textAsString() == "Prompt" }.click() | |
| onElement { isEditable }.apply { |
Footnotes
-
The official Kotlin style guide recommends a space between a function name and the opening brace of a lambda expression. This improves code readability. ↩
2 participants
The PromptBenchmark and BaselineProfileGenerator were updated to use
onElementinstead of the deprecatedonViewfor UI interaction in tests.